Being the best Drupal Code Reviewer: why we can't accept bad code

natanmoraes

The Drupal Code Review process is a vital - but often overlooked - process to keep your code consistent, easy to maintain and evolve, preventing it from becoming a "legacy non standard junk of code" nobody wants to touch - not to mention the financial impact! 

We've all been through that scenario and we just know it's not right: There is no place for bad Drupal code anymore!

In this session, I'll share my experiences as a Drupal code reviewer for CI&T, providing insights and examples on:

  • What is Code Review and its importance - Including Drupal particularities
  • The impact of bad code on performance and security¬†
  • Examples of bad code - and how it was missed - along with the impact afterwards
  • How to perform a Code Review
  • Best tools to help Code Review
  • When to use Code Review and where does it go within the process workflow
  • When you don't need to perform code review
  • Who can be a Code Reviewer

Also, I'll cover a bit on the process for Code Review on drupal.org for revieweing sandbox modules and other issues.

A look in the future - D8
With Drupal 8 and the adoption of OO design, code should get easier to evolve and maintain. But that doesn't mean the work for Code Reviewers is gone. We will discuss about that too.

Learning outcomes
After this session you should be able to have a good understanding on how to start executing code review as a must have process of your software development methodology. Moreover, you shall leave convinced that all custom code must reviewed and you will never deploy to production code that hasn't been reviewed anymore!

Session Track

Coding and Development

Experience Level

Beginner

Drupal Version